Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest suggestion: Is this grit bin here the whole year? #4749

Closed
3 of 5 tasks
FloEdelmann opened this issue Jan 13, 2023 · 5 comments · Fixed by #4754
Closed
3 of 5 tasks

Quest suggestion: Is this grit bin here the whole year? #4749

FloEdelmann opened this issue Jan 13, 2023 · 5 comments · Fixed by #4754
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Comments

@FloEdelmann
Copy link
Member

FloEdelmann commented Jan 13, 2023

General

Affected tag(s) to be modified/added: seasonal
Question asked: Is this here the whole year?

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
    seasonal tag is established, but not widely used on amenity = grit_bin yet
    → can be used to re-enable Check for existence of grit bins #2726 for non-seasonal grit bins
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary
    → survey is necessary with at least half a year in between. That's why the quest should be disabled by default, like the indoor/outdoor seating quest
  • 💤 Not an overwhelming percentage of quests have the same answer (No spam)
    → not sure, might be depending on the area, see https://overpass-turbo.eu/s/1q7A
  • 🕓 Applies to a reasonable number of map data (Worth the effort)
    → yes, see https://overpass-turbo.eu/s/1q7z

Ideas for implementation

Element selection: amenity = grit_bin and !seasonal
Proposed UI: Yes/No quest form
Quest icon: Maybe a calendar, similar to https://www.svgrepo.com/svg/362042/calendar-clock

Related issues

@westnordost
Copy link
Member

What do you need grit bins for outside winter? In other words, how would this information be useful?

@FloEdelmann
Copy link
Member Author

Basically only to enable the "check existence" quest, at least for grit bins that are there the whole year.

@matkoniecz
Copy link
Member

In other words, how would this information be useful?

This allows local mappers who remember winter(s) when bin was there and summer(s) when it was gone to tag that it is seasonal, what in turn reduces risks that less local mapper will delete seasonal grit bin during summer.

@westnordost
Copy link
Member

what in turn reduces risks that less local mapper will delete seasonal grit bin during summer.

Then, why not only ask for the existence of grit bins that are not seasonal?

@matkoniecz
Copy link
Member

Then, why not only ask for the existence of grit bins that are not seasonal?

This applies not only to SC users, but also to other mappers.

@westnordost westnordost added enhancement new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) and removed enhancement labels Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants