Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC asks me if a vacant shop is the same shop #4752

Closed
ivanbranco opened this issue Jan 14, 2023 · 1 comment · Fixed by #4756
Closed

SC asks me if a vacant shop is the same shop #4752

ivanbranco opened this issue Jan 14, 2023 · 1 comment · Fixed by #4756
Labels

Comments

@ivanbranco
Copy link

ivanbranco commented Jan 14, 2023

In the "Shops" layer, if I click "It's vacant", StreetComplete asks me if the shop is still the same shop or a different one, as when you rename a shop. In this case tho I find it quite confusing, also because both choices seems to have identical effects.

I think it shouldn't ask that question
or
it could ask "Is the name still visible?" (as suggested in the disused:* wiki page: "It no longer has an operator as such - no beer is sold - but the name is still useful for navigation.") and keep/delete the name=* based on the reply.

StreetComplete v50.2

@ivanbranco ivanbranco added the bug label Jan 14, 2023
@Helium314
Copy link
Collaborator

both choices seems to have identical effects

Actually answering that it's the same shop only removes the name and sets the shop type to vacant, without any other tag changes. Best would be to just not ask, and properly set it to vacant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants