Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycleway resurvey quest applies incorrect tags for one-way streets #4774

Closed
tapetis opened this issue Jan 29, 2023 · 1 comment
Closed

Cycleway resurvey quest applies incorrect tags for one-way streets #4774

tapetis opened this issue Jan 29, 2023 · 1 comment
Assignees
Labels

Comments

@tapetis
Copy link
Contributor

tapetis commented Jan 29, 2023

As shown in the video below, the cycleway quest applies incorrect tags when the "Is this still the cycling situation here?" question is asked for one-way streets.

How to Reproduce

device-2023-01-29-145134.mp4

The way shown in the video is https://www.openstreetmap.org/way/109539742. This way is tagged with both cycleway=lane and cycleway:right=lane, which is, of course, suboptimal tagging. However, the bug also appears on the way https://www.openstreetmap.org/way/37873577, which is tagged as just cycleway=lane. The error occurs not only when "none" is selected, but also with other options with different obscure results.

Please note, the ways above are only examples and the chosen option does not reflect the real situation on the ground.

Versions affected
v50.2

@tapetis tapetis added the bug label Jan 29, 2023
@westnordost
Copy link
Member

I think what is happening here is that the left and right side are being pre-filled with "ambiguous" (as it could be a cycle lane or an advisory cycle lane) and as "ambiguous" values are generally shown as if they are not set, they are not shown at all. Now, the user sets the right side and only the right side is being re-tagged while the left side remains the same.

So, the actual issue is that both sides of a oneway street should be shown to the user also if the side in opposite flow direction has some invalid or ambiguous value (and not only if it has a known value).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants