Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot tap on some streets to get their name for AddressStreet quest #4974

Closed
mnalis opened this issue Apr 27, 2023 · 4 comments
Closed

Cannot tap on some streets to get their name for AddressStreet quest #4974

mnalis opened this issue Apr 27, 2023 · 4 comments
Labels

Comments

@mnalis
Copy link
Member

mnalis commented Apr 27, 2023

I can click on majority of streets just fine. But some are unclickable - their name doesn't copy when I click on them.

How to Reproduce

  • go to e.g. this location (Bosiljevska ulica - https://www.openstreetmap.org/way/907569608)
  • try to solve addresses.
  • (Housenumber quest will work)
  • but in AddressStreet quest Bosiljevska ulica street will not be clickable
  • also Dubrovačka ulica street will not be clickable
  • however Ozaljska ulica street will be clickable normally

Video:

small_SVID_20230427_171204_1.mp4

Refreshing the map does not seem to help. It is always reproducible on that two streets, and seems to works on all other streets. Related issue #3816 is supposed to be fixed.
The two problematic roads are highway=residential and the one that is working is highway=secondary, but I've never before had issues with residential roads being ignored in that quest.

Expected Behavior

  • when clicking on any of the streets, its name would get copied, so AddressStreet quest can be solved

Versions affected
EMUI 12, SC v52.0

@mnalis mnalis added the bug label Apr 27, 2023
@mnalis
Copy link
Member Author

mnalis commented Apr 27, 2023

Interestingly, if I answer surface quest on that street, then I can click on it?

small_SVID_20230428_013606_1.mp4

@mnalis
Copy link
Member Author

mnalis commented Apr 27, 2023

But it does seem to be related to that #3797.

Indeed if I click closer to the end of the road, it starts to work. It seems strange though, as all data is loaded, and even when endpoint of the way is displayed on the visible part of the map, clicking on road doesn't work unless click is closer to the edge.

Also it doesn't explain why answering surface quests seems to fix the issue even if nodes of the way are no longer visible? Might it be caching related?

small_SVID_20230428_014601_1.mp4

@westnordost
Copy link
Member

This is a known problem or limitation.

Tap on the road more closely to an intersection, then it works.

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Apr 28, 2023
@westnordost
Copy link
Member

FYI this is because how this function is defined:

/**
* Gets all elements and geometries inside [bbox]. This returns all nodes, all ways containing
* at least one of the nodes, and all relations containing at least one of the ways or nodes,
* and their geometries.
* If data is not cached, tiles containing the [bbox] are fetched from database and cached.
*/
fun getMapDataWithGeometry(bbox: BoundingBox): MutableMapDataWithGeometry = synchronized(this) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants