Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest CyclewayOverlay removes oneway:bicycle=no #5367

Closed
tordans opened this issue Nov 7, 2023 · 5 comments
Closed

Quest CyclewayOverlay removes oneway:bicycle=no #5367

tordans opened this issue Nov 7, 2023 · 5 comments
Assignees
Labels

Comments

@tordans
Copy link

tordans commented Nov 7, 2023

How to Reproduce

It looks like, in some cases the Quest CyclewayOverlay removes oneway:bicycle=no.

This was reported in https://www.openstreetmap.org/changeset/141434793 (OSMCha) for this way "Schlangenbader Straße"

  • Version 27 is SC
  • Version 28+29 are the manual fix
image

Expected Behavior

User Mopshase12 founds this to be an unexpected change. In the changeset discussion he said an additionale question might be needed to make sure this change is intended.

Versions affected

The version used was StreetComplete 54.0

@tordans tordans added the bug label Nov 7, 2023
@westnordost westnordost removed the bug label Nov 7, 2023
@westnordost
Copy link
Member

westnordost commented Nov 7, 2023

The fact that oneway:bicycle can be removed with StreetComplete is not a bug.

Please provide additional information on what is the current behavior of the app and what is the expected behavior of the app, preferably with screenshots.

(FYI: To my knowledge, there are already several mechanisms to prevent users from accidentally choosing the wrong answer.)

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Nov 7, 2023
@Helium314
Copy link
Collaborator

Tried in SCEE 55.0, so I can modify tags. There are no relevant changes compared to SC 54.0 in the cycleway overlay.

From the changes it appears the user only set the western cycleway (right side in OSM) to none, I can't reproduce the tagging otherwise.
When clicking ok, there is a dialog with "Are you sure that cyclists are not allowed to use this one-way street in both directions? If you’re unsure, look for a sign at the end of the street.", so the user clearly knew they were marking the road as one-way for cyclists.

However, the user answered only for cycleway:right and left the other side undefined, where they might have to check for a sign at the end of the street. SC adding a change related to the other side is unexpected here.

@westnordost
Copy link
Member

Mh, so I understand correctly that it was both a mistake by the user but also a bug in the app?

I.e. the app should not assume any one-way-ness for cyclists as long as the cycleway on the contra-flow side of the oneway is not set? (Best start with a test case, to see what's going on. There must be some reason why SC interprets the situation that way)

@Helium314
Copy link
Collaborator

I.e. the app should not assume any one-way-ness for cyclists as long as the cycleway on the contra-flow side of the oneway is not set?

I guess so, but as you mention: there might be a reason for the current behavior. Maybe related to the possibility of having both directions on one side.

@westnordost westnordost self-assigned this Nov 12, 2023
@westnordost
Copy link
Member

No, it was a bug alright. The algorithm that would determine if a road is a now also a oneway for cyclists didn't take into account (correctly) that the user is able to also define the cycleway for only one side. In that case, the side that likely doesn't matter for the contraflow.

@westnordost westnordost added bug and removed feedback required more info is needed, issue will be likely closed if it is not provided labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants