Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Don't scan binary files (webm) #4167

Closed
infacto opened this issue Feb 14, 2023 · 3 comments · Fixed by #4171
Closed

[Bug]: Don't scan binary files (webm) #4167

infacto opened this issue Feb 14, 2023 · 3 comments · Fixed by #4171

Comments

@infacto
Copy link

infacto commented Feb 14, 2023

Why searching binary files? In my case it shows errors of unknown words in *.webm files.

Example (modified):

assets\my-video.webm:12345:12 - Unknown word (FOSIP)

Version: 6.24.0

Workaround: Add to ignorePaths.

Btw. should we also scan *.svg file? I added it to ignorePaths. But it's more binary than text in my opinion.

Is there a exclude or include logic? Maybe include is better?
Also for my config file (cspell.json), I wish there is a include files list. Inverted logic. Did I miss something? I think you can only specify include path as command arguments cspell my-path. We could also allow to define this in the config file.

@Jason3S
Copy link
Collaborator

Jason3S commented Feb 14, 2023

@infacto,

The file type was not in the know list of extensions.

As far as .svg files, that needs to be on an individual basis. If you edit .svg, then I think you might want to spell check your comments.

@Jason3S
Copy link
Collaborator

Jason3S commented Feb 14, 2023

Is there a exclude or include logic? Maybe include is better? Also for my config file (cspell.json), I wish there is a include files list. Inverted logic. Did I miss something? I think you can only specify include path as command arguments cspell my-path. We could also allow to define this in the config file.

There is a files section in the config that allows you to define the default globs to scan.

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants