Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the approach to custom decorations #3239

Merged
merged 4 commits into from May 7, 2024
Merged

fix: change the approach to custom decorations #3239

merged 4 commits into from May 7, 2024

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented May 7, 2024

  • All issues are now collected on the client side.
  • The client controls if issues are shown by VS Code or custom.
  • It is possible to force VS Code rendering by scheme
  • It is possible to toggle the spelling display by command.
  • Rename decorateIssues to useCustomDecorations
  • Remove diagnosticLevelSCM replaced with doNotUseCustomDecorationForScheme
  • Added doNotUseCustomDecorationForScheme to control rendering by scheme.

- All issues are now collected on the client side.
- The client controls if issues are shown by VS Code or custom.
- It is possible to force VS Code rendering by scheme
- It is possible to toggle the spelling display by command.
@Jason3S Jason3S marked this pull request as ready for review May 7, 2024 17:33
@Jason3S Jason3S merged commit bc6df01 into main May 7, 2024
16 checks passed
@Jason3S Jason3S deleted the dev-diags branch May 7, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant