Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cSpell.ignorePaths default paths can not be overwritten #55

Closed
micnic opened this issue Jan 12, 2017 · 11 comments
Closed

cSpell.ignorePaths default paths can not be overwritten #55

micnic opened this issue Jan 12, 2017 · 11 comments

Comments

@micnic
Copy link

micnic commented Jan 12, 2017

I am developing my node modules inside a node_modules directory and wanted to be able to spellcheck the code. I removed the **/node_modules/** option from the cSpell.ignorePaths array, but the files from the this directory are still not spellchecked. Even if I modify the user or the workspace settings it does not help.

Tested environment:
OS: Ubuntu 16.04
VSCode: 1.8.1
Spell-checker: 0.14.3

@Jason3S Jason3S added the bug label Jan 12, 2017
@Jason3S
Copy link
Collaborator

Jason3S commented Jan 12, 2017

Thank you. I'll check it out.

@Jason3S
Copy link
Collaborator

Jason3S commented Jan 14, 2017

cSpell also excludes the search exclude list.

// Configure glob patterns for excluding files and folders in searches. Inherits all glob patterns from the files.exclude setting.
  "search.exclude": {
    "**/node_modules": true,
    "**/bower_components": true
  },

Add this to your workspace settings:

// Configure glob patterns for excluding files and folders in searches. Inherits all glob patterns from the files.exclude setting.
  "search.exclude": {
    "**/bower_components": true
  },

@micnic
Copy link
Author

micnic commented Jan 14, 2017

I am sorry for being annoying, but it is still not working :)

I added the following settings to the to the workspace:

{
	"cSpell.ignorePaths": [
		"**/vscode-extension/**",
		"**/.git/**",
		".vscode",
		"typings"
	],
	"search.exclude":{
		"**/bower_components": true
	}
}

The project has this location:
/home/micnic/repos/github/node_modules/*MODULE_NAME*

I played around with different settings and restarting VSCode, but nothing helps. I always get this message at the bottom:
cspell
It's enough to move the file outside the node_modules directory and the spell checking works fine

@Jason3S
Copy link
Collaborator

Jason3S commented Jan 14, 2017

I'll take another look.

@Jason3S
Copy link
Collaborator

Jason3S commented Jan 14, 2017

This seems to be an issue with VS Code. It is not honoring the workspace settings.
I just stepped through it with the debugger. The **/node_modules is getting added by VS Code even after I took it out of the search.exclude list.

There is a minor bug in how we check the glob, that might fix this issue for you.

In the mean time, there is a work around by using npm link. That allows you to have your node_modules in a different location.

@micnic
Copy link
Author

micnic commented Jan 14, 2017

Thanks for the information, should this bug be reported to the VSCode repo?

@Jason3S
Copy link
Collaborator

Jason3S commented Jan 14, 2017

I think I have fixed the spell checker so it will work in your case. Please let me know.

@Jason3S
Copy link
Collaborator

Jason3S commented Jan 14, 2017

The fix should be in 0.14.6

@micnic
Copy link
Author

micnic commented Jan 14, 2017

Works fine with 0.14.6, thank you very much

@SlurpTheo
Copy link

0.14.6 & VS Code: 1.31.1, I can't get files with a node_modules somewhere in their path to spell-check.

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants