Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix set within Map child element #105

Merged
merged 3 commits into from Aug 19, 2021
Merged

fix set within Map child element #105

merged 3 commits into from Aug 19, 2021

Conversation

geseq
Copy link
Collaborator

@geseq geseq commented Jun 13, 2021 •
edited by hanzei

Summary

closes #97

Fixes Set call when trying to set a value into an inner element that's a Map type as described in #97

Checklist

  • Tests are passing: task test
  • Code style is correct: task lint

@geseq
Copy link
Collaborator Author

geseq commented Jun 13, 2021

@hanzei another one

@geseq
Copy link
Collaborator Author

geseq commented Jul 7, 2021

depends on some changes in #104 I'll update it again once that is merged

hanzei
hanzei reviewed Jul 16, 2021
View reviewed changes
accessors.go Outdated Show resolved Hide resolved
@hanzei hanzei added this to the v1.0 milestone Jul 16, 2021
geseq
geseq commented Jul 22, 2021
View reviewed changes
Copy link
Collaborator Author

@geseq geseq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to do this on my phone

accessors.go Outdated Show resolved Hide resolved
accessors.go Outdated Show resolved Hide resolved
accessors.go Outdated Show resolved Hide resolved
accessors.go Outdated Show resolved Hide resolved
@geseq
Copy link
Collaborator Author

geseq commented Jul 22, 2021

ready to review @hanzei

@hanzei hanzei merged commit 27373ce into stretchr:master Aug 19, 2021
@geseq geseq deleted the set-within-map branch August 19, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4. to release
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging this pull request may close these issues.

Set operator with not expected behavior
2 participants
@geseq @hanzei