Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow non-facilitators to delete a submitted idea within 5s of submission #35

Closed
4 tasks
williamcodes opened this issue Feb 15, 2017 · 5 comments
Closed
4 tasks

Comments

@williamcodes
Copy link
Contributor

williamcodes commented Feb 15, 2017

As a non-facilitator participant who has mistakenly added an idea to the board,
I would like to be able to delete that idea from the board,
So that I don't feel I have cluttered the board.

Acceptance Criteria

  • non-facilitators see the delete button beside each of their ideas
  • after 5s have elapsed since the idea was persisted, the delete button fades out.
    • Note: this was initially in story disallow deletion of ideas that have been on the board for > 5s #53, which was written prior to the facilitator deletion story. The feeling is that we don't want to merge/deploy this deletion feature in an incomplete state, as ideas that have been on the board for 5s would allow folks to remove ideas that other participants have already taken in.
  • when a non-facilitator deletes an idea they've submitted, all connected clients see the idea removed from their board.
  • upon refreshing the page, the deleted item is not displayed
@vanderhoop
Copy link
Contributor

hey @williamcodes, love that you went ahead and made this issue. One small piece of feedback on the format: ideally, all user stories are written such that they reveal the value to the user. For example, this story could be written as

As a retro participant who has mistakenly added an idea to the board,
I would like to be able to delete that idea from the board,
So that I don't feel I have cluttered the board

And then the specifics of the UI interactions and results could be shifted down to an Acceptance Criteria list where you can get more granular.

@vanderhoop
Copy link
Contributor

vanderhoop commented Feb 15, 2017

@williamcodes I realize you may have just fired this issue off to get it on the board, so sorry to nitpick in that case. I'm happy you felt empowered to create it. Thanks!

@vanderhoop vanderhoop changed the title add ability to delete comments allow deletion of an idea Feb 16, 2017
@vanderhoop vanderhoop changed the title allow deletion of an idea allow deletion of a submitted idea Feb 16, 2017
@williamcodes
Copy link
Contributor Author

@vanderhoop that's great feedback, thanks, updating the story

@zmackie
Copy link
Contributor

zmackie commented Mar 7, 2017

@vanderhoop Yo I wanna work on this one. Can I get added to the repo?

@vanderhoop
Copy link
Contributor

@Zanadar yo! if and when you make a pull request for this guy, can you make it to the feature/deleting-submitted-ideas branch? I want to keep this off master until story #39, "disallow users from deleting other users' ideas", is complete, as it could introduce a weird intermediate state that could be off-putting to users. Thanks!

@vanderhoop vanderhoop changed the title allow deletion of a submitted idea allow non-facilitators to delete a submitted idea within 5s of submission Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants