Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Assets] AssetCompiler uses spatialized flag for channel count #1944

Open
adrsch opened this issue Oct 15, 2023 · 1 comment
Open

[Assets] AssetCompiler uses spatialized flag for channel count #1944

adrsch opened this issue Oct 15, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@adrsch
Copy link
Contributor

adrsch commented Oct 15, 2023

Version: 4.1.0.1

Describe the bug
Instead of detecting the channel count from the audio file, or as an explicit import option, the spatialized flag is used to set the channel count to 1 if true, 2 if false.

To Reproduce
Steps to reproduce the behavior:

  1. Import a mono wav file without the "spatialized" flag set.
  2. Try to play from an Audio emitter component
  3. It will give you an exception that the channel count is greater than 1

Expected behavior
A mono file will be imported with a channel count of 1.

Screenshots
If applicable, add screenshots to help explain your problem (use GitHub drag & drop)

Log and callstacks
This is caused by SoundAssetCompiler.DoCommandOverride, line 54.

@adrsch adrsch added the bug Something isn't working label Oct 15, 2023
@adrsch
Copy link
Contributor Author

adrsch commented Oct 15, 2023

Reading into this a bit, ffmpeg does not seem to be recommended for getting this kind of info - instead, ffprobe is recommended.

It's usually bundled in downloads of ffmpeg, but it isn't included with Stride currently. So that path for solving the bug would be to add ffprobe as a dependency, and use it for channel info (also, we could use it for sample rate too)

@adrsch adrsch changed the title AssetCompiler uses spatialized flag for channel count [Assets] AssetCompiler uses spatialized flag for channel count Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant