Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Re-factor applying NetworkPolicy with copying secrets #8936

Closed
see-quick opened this issue Aug 2, 2023 · 1 comment
Closed

[ST] Re-factor applying NetworkPolicy with copying secrets #8936

see-quick opened this issue Aug 2, 2023 · 1 comment
Assignees
Milestone

Comments

@see-quick
Copy link
Member

We should refactor our current way of creating an auxiliary namespace, application of NP and copying of pull secret (in system tests) and follow the rule DRY.

KubeClusterResource.getInstance().createNamespace(CollectorElement.createCollectorElement(simpleClassName), Constants.TEST_SUITE_NAMESPACE);
NetworkPolicyResource.applyDefaultNetworkPolicySettings(extensionContext, Collections.singletonList(Constants.TEST_SUITE_NAMESPACE));
StUtils.copyImagePullSecrets(Constants.TEST_SUITE_NAMESPACE);
@see-quick see-quick added this to the 0.37.0 milestone Aug 2, 2023
@scholzj scholzj changed the title Re-factor applying NetworkPolicy with copying secrets [ST] Re-factor applying NetworkPolicy with copying secrets Aug 29, 2023
@scholzj scholzj removed this from the 0.37.0 milestone Sep 1, 2023
@im-konge im-konge self-assigned this Jan 7, 2024
@im-konge im-konge added this to the 0.40.0 milestone Jan 7, 2024
@im-konge
Copy link
Member

im-konge commented Jan 7, 2024

Done in #9496

@im-konge im-konge closed this as completed Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants