Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KRaft]: Make KafkaRoller aware of KRaft mode #9373

Open
tinaselenge opened this issue Nov 21, 2023 · 2 comments
Open

[KRaft]: Make KafkaRoller aware of KRaft mode #9373

tinaselenge opened this issue Nov 21, 2023 · 2 comments
Assignees

Comments

@tinaselenge
Copy link
Contributor

Related problem

Currently KafkaRoller evaluates each node based on the role defined in NodeRef. However, both KRaft and Zookeeper broker would have broker role defined in its NodeRef, therefore KafkaRoller cannot tell which mode it is running in. KafkaRoller needs to identify the current active controller and depending on which mode the cluster is in, it needs to make a different API call (e.g. describeCluster against broker nodes or describeQuorum against controller nodes). Since it cannot tell which mode the cluster is running on, when running in KRaft mode, it makes both API calls and results in inconsistent and duplicated logs reporting the active controller. In KRaft, describeCluster returns a random broker and will mean this broker is deferred.

Suggested solution

In future this can be improved by telling KafkaRoller whether the cluster is in KRaft mode or not.

Alternatives

No response

Additional context

No response

@tinaselenge tinaselenge changed the title [Enhancement]: Make KafkaRoller aware of which mode it is running on [Enhancement]: Make KafkaRoller aware when running in KRaft mode Nov 21, 2023
@tinaselenge tinaselenge changed the title [Enhancement]: Make KafkaRoller aware when running in KRaft mode [Enhancement]: Make KafkaRoller aware of KRaft mode Nov 21, 2023
@scholzj
Copy link
Member

scholzj commented Nov 30, 2023

Discussed on the community call on 30.11.2023: This should be fixed. @tinaselenge do you plan to work on this?

@scholzj scholzj changed the title [Enhancement]: Make KafkaRoller aware of KRaft mode [KRaft]: Make KafkaRoller aware of KRaft mode Dec 4, 2023
@tinaselenge
Copy link
Contributor Author

@scholzj yes, I can work on this.

@tinaselenge tinaselenge self-assigned this Dec 5, 2023
@scholzj scholzj added the KRaft label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants