Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertion usage in the Backoff class #312

Closed
ppatierno opened this issue Mar 13, 2018 · 0 comments · Fixed by #347
Closed

Remove assertion usage in the Backoff class #312

ppatierno opened this issue Mar 13, 2018 · 0 comments · Fixed by #347

Comments

@ppatierno
Copy link
Member

The current BackOff class implementation uses assert for checking parameter values in the constructor.
It means that TC and CC need to be run with -ea option on the command line.
In order to do that, it's better having the checking logic encapsulated into the code not relying on "external" options.
The issue is about moving away from assert usage and having if / throw checks instead.
At same time it's needed to amend the check-style rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant