Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Stirmzi Oauth in the Test Container containers to allow testing of OAuth #63

Open
scholzj opened this issue Dec 28, 2023 · 2 comments

Comments

@scholzj
Copy link
Member

scholzj commented Dec 28, 2023

In some situation, it might be useful to have the Strimzi Oauth library packaged into the Test Container images as well to allow testing against it in tests.

@see-quick
Copy link
Member

I am thinking about it. So this is current set of images:

REPOSITORY                   TAG                          IMAGE ID       CREATED              SIZE
strimzi/test-container       latest-kafka-3.6.1-ppc64le   05365a653b6b   2 seconds ago        491MB
strimzi/test-container       latest-kafka-3.6.1-arm64     af219b19bfa9   3 seconds ago        482MB
strimzi/test-container       latest-kafka-3.6.1-s390x     edc2318f6d2c   5 seconds ago        443MB
strimzi/test-container       latest-kafka-3.6.1-amd64     83ec1831ae31   7 seconds ago        471MB
strimzi/test-container       latest-kafka-3.5.1-ppc64le   2f53604bf871   10 seconds ago       484MB
strimzi/test-container       latest-kafka-3.5.1-arm64     aa6c24270fc4   12 seconds ago       475MB
strimzi/test-container       latest-kafka-3.5.1-s390x     6219d2bd8a6b   13 seconds ago       435MB
strimzi/test-container       latest-kafka-3.5.1-amd64     0f64674b283f   15 seconds ago       464MB
strimzi/test-container       latest-kafka-3.4.1-ppc64le   bb21a9df0291   18 seconds ago       484MB
strimzi/test-container       latest-kafka-3.4.1-arm64     0c637e04c345   20 seconds ago       474MB
strimzi/test-container       latest-kafka-3.4.1-s390x     ac24b93439ea   21 seconds ago       435MB
strimzi/test-container       latest-kafka-3.4.1-amd64     d8ba6ff1c276   23 seconds ago       463MB
strimzi/test-container       latest-kafka-3.3.2-ppc64le   4a6326322af5   26 seconds ago       484MB
strimzi/test-container       latest-kafka-3.3.2-arm64     b2765d349e3e   28 seconds ago       474MB
strimzi/test-container       latest-kafka-3.3.2-s390x     75d7966245ab   30 seconds ago       435MB
strimzi/test-container       latest-kafka-3.3.2-amd64     4e71bed5898e   31 seconds ago       463MB
strimzi/test-container       latest-kafka-3.2.3-ppc64le   333342b8b345   34 seconds ago       481MB
strimzi/test-container       latest-kafka-3.2.3-arm64     da0f91dcf96f   36 seconds ago       472MB
strimzi/test-container       latest-kafka-3.2.3-s390x     10a934c65353   37 seconds ago       433MB
strimzi/test-container       latest-kafka-3.2.3-amd64     d6df51fc2f91   39 seconds ago       461MB
strimzi/test-container       latest-kafka-3.1.2-ppc64le   13689df09fd9   42 seconds ago       465MB
strimzi/test-container       latest-kafka-3.1.2-arm64     ae507cac3c88   43 seconds ago       456MB
strimzi/test-container       latest-kafka-3.1.2-s390x     0fa662495e07   45 seconds ago       417MB
strimzi/test-container       latest-kafka-3.1.2-amd64     7e23affb363b   46 seconds ago       445MB
strimzi/test-container       latest-kafka-3.0.2-amd64     448ee576dc3f   54 seconds ago       443MB
strimzi/test-container       latest-kafka-2.8.2-ppc64le   b5a4d8737caa   56 seconds ago       449MB
strimzi/test-container       latest-kafka-2.8.2-arm64     1c7b3b666fcf   58 seconds ago       439MB
strimzi/test-container       latest-kafka-2.8.2-s390x     3a810d64d03f   59 seconds ago       400MB

but if we want to include the Strimzi Oauth library we would need to:

  1. (test-container-images) change - Provide a new set of images (which includes the OAuth library packaged inside DockerFiles)
  2. then we should add code into the test-container repo where we could enable OAuth etc.

WDYT?

@scholzj
Copy link
Member Author

scholzj commented Feb 5, 2024

I'm not sure you need to do it for all the old version. Do we actually use them anywhere? Also, OAuth has many different ways to be configured. So not sure how exactly would the code to enable OAuth look like. But in gneral yes, these are the things we would need I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants