Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read deployment data from environment #28

Closed
emmiegit opened this issue Sep 21, 2017 · 5 comments
Closed

Read deployment data from environment #28

emmiegit opened this issue Sep 21, 2017 · 5 comments

Comments

@emmiegit
Copy link
Collaborator

Eventually all bots with standardize on reading certain details like the bot token from environment variables.

@emmiegit
Copy link
Collaborator Author

@robstolarz @raylu Given our discussion, will we still be using configuration via the environment, or will we be keeping what we have now?

@raylu
Copy link
Member

raylu commented Sep 30, 2017

¯\(°_o)/¯

@robstolarz
Copy link
Contributor

I'll take my bike shed in blue thanks :)

I think we can just pass them as arguments and leave a note as to why we do that. Argparse is great.

@emmiegit
Copy link
Collaborator Author

emmiegit commented Oct 1, 2017

Right now the only argument we really accept is -d, for enabling debug logging. I suppose we could have every config option overridable with a CL argument.

@robstolarz
Copy link
Contributor

Ah, we don't need quite that much. Just parameters for the database and the token would be enough, I think.

(unless you'd really like to do that...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants