Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional filters like active #678

Closed
rnmp opened this issue Dec 21, 2019 · 0 comments
Closed

Add support for additional filters like active #678

rnmp opened this issue Dec 21, 2019 · 0 comments

Comments

@rnmp
Copy link
Contributor

rnmp commented Dec 21, 2019

Heyo.

I just started using this gem and I noticed that things like Stripe::Plan.list(active: true) will get ignored and return the full list instead. I checked out the code and noticed there's no logic around filters like active in list.rb.

Other than that, thanks for making this gem, it's making my life easier, especially since this is the first time I'm building for Stripe.

EDIT: Made the change myself since you guys are in search for contributors :P

@rnmp rnmp changed the title Add support for filters Add support for additional filters like active Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants