Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing implicit/default Layouts #9

Open
erik-stripe opened this issue Jan 5, 2016 · 1 comment
Open

Consider removing implicit/default Layouts #9

erik-stripe opened this issue Jan 5, 2016 · 1 comment

Comments

@erik-stripe
Copy link
Contributor

Since an efficient layout is such a crucial part of successfully using Bonsai, it might be better to have folks create their own, rather than providing implicit instances. Look into what it would take to remove the implicits and just use builders.

@tixxit
Copy link
Contributor

tixxit commented Jan 5, 2016

I definitely generally agree.

I think the future will likely have people using some sort of Generic-style builder that'll remove a lot of the complexity in constructing instances in the common case (eg Layout.generic[MyLabelType]).

Also, serialization (eg on-disk) is a thing we need to start thinking about. It's unclear to me if we want to conflate in-memory layout with on-disk, but there are some obvious benefits in load time if we do (also, can even imagine an on-disk, memory-mapped back Vec). However, in that case we really need to be sure we don't accidentally swap out the Layout being used, so there can be no generic implicits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants