Skip to content

Commit

Permalink
Adjust reload{,ing}_for_preload_upgrade names for the new reality
Browse files Browse the repository at this point in the history
It's just reload_for_upgrade now that we always reload einhorn on
upgrades (:
  • Loading branch information
asf-stripe committed May 26, 2014
1 parent f2f809f commit 8aeaee9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions lib/einhorn.rb
Expand Up @@ -57,7 +57,7 @@ def self.default_state
:respawn => true,
:upgrading => false,
:smooth_upgrade => false,
:reloading_for_preload_upgrade => false,
:reloading_for_upgrade => false,
:path => nil,
:cmd_name => nil,
:verbosity => 1,
Expand Down Expand Up @@ -382,9 +382,9 @@ def self.run
preload

# In the middle of upgrading
if Einhorn::State.reloading_for_preload_upgrade
if Einhorn::State.reloading_for_upgrade
Einhorn::Command.upgrade_workers
Einhorn::State.reloading_for_preload_upgrade = false
Einhorn::State.reloading_for_upgrade = false
end

while Einhorn::State.respawn || Einhorn::State.children.size > 0
Expand Down
10 changes: 5 additions & 5 deletions lib/einhorn/command.rb
Expand Up @@ -235,7 +235,7 @@ def self.reload
Process.wait(upgrade_sentinel)
unless $?.exitstatus.zero?
Einhorn.log_error("Can not initiate reload since sentinel process exited with #{$?.exitstatus}", :reload)
Einhorn::State.reloading_for_preload_upgrade = false
Einhorn::State.reloading_for_upgrade = false
read.close
return
end
Expand All @@ -247,7 +247,7 @@ def self.reload
Einhorn::Compat.exec(*respawn_commandline)
rescue SystemCallError => e
Einhorn.log_error("Could not reload! Attempting to continue. Error was: #{e}", :reload)
Einhorn::State.reloading_for_preload_upgrade = false
Einhorn::State.reloading_for_upgrade = false
read.close
end
end
Expand Down Expand Up @@ -385,7 +385,7 @@ def self.full_upgrade(options={})
options = {:smooth => false}.merge(options)

Einhorn::State.smooth_upgrade = options.fetch(:smooth)
reload_for_preload_upgrade
reload_for_upgrade
end

def self.full_upgrade_smooth
Expand All @@ -395,8 +395,8 @@ def self.full_upgrade_fleet
full_upgrade(:smooth => false)
end

def self.reload_for_preload_upgrade
Einhorn::State.reloading_for_preload_upgrade = true
def self.reload_for_upgrade
Einhorn::State.reloading_for_upgrade = true
reload
end

Expand Down

0 comments on commit 8aeaee9

Please sign in to comment.