This repository has been archived by the owner on Apr 8, 2021. It is now read-only.
updated schema to include more escalation policy and schedule data #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-stripe
suggested changes
Sep 5, 2017
pd2pg.rb
Outdated
| "schedules/#{s["id"]}/users", | ||
| { since: Time.now.strftime("%Y-%m-%d") }, | ||
| false) { | ||
| |u| convert_user_schedule(u, s["id"]) |
There was a problem hiding this comment.
Please use do |u| syntax for multiple-line blocks (with the |u| on the same line as the do); it gets really confusing to read otherwise.
| if should_log | ||
| log("refresh_bulk.update", table_name: table_name, total: records.length) | ||
| end | ||
| database_update(table_name, records) |
There was a problem hiding this comment.
with the addition of this, is the Yields each API value to a block above still true?
There was a problem hiding this comment.
Yes. It's kind of hard to see, but the database_update method is code I copypasted from the bottom of this method into its own method. So it's pretty much the same behavior, but "decomposed". The yield is still used!
|
Done addressing comments! |
|
Can I get permission on this repo to merge this? (Or can you merge this?) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pull more data from the PagerDuty v1 API. The schema now includes escalation rules and which users are in each schedule. The new tables are: escalation_rules, escalation_rule_users, escalation_rule_schedules, and user_schedule. escalation_policies also now includes a column for how many times it loops.
Motivation
We want to use this data to do more analysis on our use of PD.
Test plan
Ran on local machine and wrote SQL queries for sanity testing.
Rollout/monitoring/revert plan
None
Reviewer expectation
Comments on the schema choices would be helpful, because I wasn't sure if I was representing the PD data with the right SQL idioms.