Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Please add CRUD methods to StripeService class with override those in successor classes #1248

Closed
evorios opened this issue Aug 6, 2018 · 2 comments

Comments

@evorios
Copy link

evorios commented Aug 6, 2018

I want to write my custom wrapper around this methods because it all have standart call var result = service.Get(Id);

@remi-stripe
Copy link
Contributor

@evorios Would you be able to provide a bit more details around the functionality we're missing and what you want us to add to the library? Even some pseudo-code example would be useful!

@ob-stripe
Copy link
Contributor

If I understand correctly, @evorios would like to have CRUD methods (Create, Get, etc.) be defined in the StripeService / StripeBasicService classes.

We cannot do this because not all services implement all CRUD methods (in fact, most services don't). However, in #1269 we've added interfaces that can be used to know which CRUD methods are implemented by a service.

This will be released in the next major version (cf. #1293) -- no ETA yet but it shouldn't be too long.

Closing this, but feel free to reply if you think interfaces won't work for your usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants