StripeClient instance per controller vs. singleton

[HappyNomad]

I'm starting my first Stripe integration and need to know which of the following mutually exclusive alternatives, for Asp.Net Core, is the preferred approach.

Option A

Controller constructors have new StripeClient(...

Option B

ConfigureServices in Startup.cs has:

services.AddSingleton<IStripeClient, StripeClient>(s => new StripeClient(

I've thoroughly searched but can't find the answer to this basic question. I hope I get one here.

[pakrym-stripe]

Hey, @HappyNomad, sorry for the long response. Option B will be more performant and scale better because you are avoiding creating new HttpClient for every request.

[HappyNomad]

Good to hear from you, @pakrym-stripe .

Option B will be more performant and scale better because you are avoiding creating new HttpClient for every request.

Yes, I figure it would be. But I find it odd that none of Stripe's samples do it that way.

[pakrym-stripe]

Hey, have you seen some ASP.NET Core-specific samples that do that? Or do you mean the general-purpose samples?

[HappyNomad]

I only follow Asp.Net Core samples since that's what I use on the backend.

[pakrym-stripe]

Can you link to the sample you are following? I'll try to see if we can make it better.

[HappyNomad]

Thanks for your interest in improving the samples. I followed along with the Stripe.net playlist on Youtube. In particular, I watched and rewatched the episodes on setting up an Asp.Net Core project and accepting a payment.

[bobbyangers]

In Core; the lifetime of the HttpClient is managed; and one should rely on that. It's not exactly singleton, it's shared.

This said, it should be recommended that for long-running services; it should create a transient instance of IStripeClient and use the IHttpClientFactory to resolve the "current" instance of the HttpClient

In pre-Core a singleton is used.

[cecilphillip-stripe]

@pakrym-stripe what do you think about using something like this using the httpclient factory

   services.AddHttpClient("Stripe");
   services.AddTransient<IStripeClient, StripeClient>(s =>
   {
       var clientFactory = s.GetRequiredService<IHttpClientFactory>();
       var httpClient = new SystemNetHttpClient(
          httpClient: clientFactory.CreateClient("Stripe"),
          maxNetworkRetries: StripeConfiguration.MaxNetworkRetries,
          appInfo: appInfo,
          enableTelemetry: StripeConfiguration.EnableTelemetry);

        return new StripeClient(apiKey: StripeConfiguration.ApiKey, httpClient: httpClient);
   });

[pakrym-stripe]

@cecilphillip-stripe, looks great!

[cecilphillip-stripe]

@HappyNomad Is this resolved for you?

[pakrym-stripe]

Closing as the original question is answered. The general DI support can be discussed in #1882