Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript charge.status is defined as string instead of explicit values #1330

Closed
davidbielik opened this issue Jan 13, 2022 · 2 comments
Closed

Typescript charge.status is defined as string instead of explicit values #1330

davidbielik opened this issue Jan 13, 2022 · 2 comments
Assignees
@dcr-stripe

Comments

@davidbielik
Copy link
Contributor

Hi, I noticed that charge.status is defined as string instead of "succeeded" | "pending" | "failed", whereas other entities like Subscription.status is explicitly defined.
@davidbielik davidbielik changed the title Typescript charge.status is string instead of enum Typescript charge.status is defined as string instead of explicit values Jan 13, 2022
@dcr-stripe
Copy link
Contributor

Hi @davidbielik , thanks for the report! Let me see if we can change this to an enum and get back to you!

@dcr-stripe dcr-stripe self-assigned this Jan 18, 2022
@dcr-stripe dcr-stripe mentioned this issue Jan 19, 2022
Merged
@dcr-stripe
Copy link
Contributor

This is now fixed and released in https://github.com/stripe/stripe-node/releases/tag/v8.198.0.

Thanks again for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcr-stripe dcr-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidbielik @dcr-stripe