Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw annotation in php-doc #491

Open
mrfreitas opened this issue Jul 6, 2018 · 2 comments
Open

Throw annotation in php-doc #491

mrfreitas opened this issue Jul 6, 2018 · 2 comments
Labels

Comments

@mrfreitas
Copy link

Please add @throws annotation to you library so the phpStorm can know what exceptions it needs to handle.
For instance the Charge::create() is throwing the Card, ApiConnection and InvalidRequest, but the phpstorm is marking those exceptions as never thrown. This is really annoying.
screenshot at jul 06 14-52-17

Thanks.

@ob-stripe
Copy link
Contributor

Hi @mrfreitas, thanks for the suggestion! I don't think we'll be able to tackle this immediately, but I'm going to tag this as future and we'll keep this in mind in future versions.

@TomKriek
Copy link

TomKriek commented Oct 9, 2018

Maybe it's better to have a general exception handler for the Stripe exceptions. Since each function/api call could potentially throw the exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants