Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the payment sheet DX #505

Closed
thorsten-stripe opened this issue Aug 11, 2021 · 0 comments · Fixed by #506
Closed

Enhance the payment sheet DX #505

thorsten-stripe opened this issue Aug 11, 2021 · 0 comments · Fixed by #506
Assignees
Labels
enhancement New feature or request P0 Address these issues first

Comments

@thorsten-stripe
Copy link
Contributor

You can initPaymentSheet with bad params and it either crashes or does not validate and return an error. Validating the params passed and ensuring a developer-friendly error message is returned is vital as it helps users self-serve to correct themselves.

  • Case A: pass customerEphemeralKeySecret: “123” on initPaymentSheet(), the SDK does not return an error, instead tries to present PaymentSheet then dismisses. Really hard for a user to debug and self help as there’s no error message. A support interaction of a user running into this issue zendesk link and second Zendesk link where the user passes a publishable key instead of EphemeralKey secret.
  • Case B pass paymentIntentClientSecret: “abc”, no validation, instead app just crashes.
  • Case c pass dummy customerId, above, app crashes.
  • Case d) pass a valid ephemeral key, but no customer param, app crashes.

@arekkubaczkowski please investigate whether the native SDKs can take care of any of this, and how we can prevent the crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P0 Address these issues first
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants