Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace proto.Marshal with direct call to Marshal's #1018

Merged
merged 4 commits into from Jan 24, 2023

Conversation

andrewa-stripe
Copy link
Contributor

Summary

Replace proto.Marshal with direct call to Marshal's

Motivation

Saw veneur prevalent in performance profiles

Test plan


# before: proto.Marshal
BenchmarkSerialization/UDP_plain_span_with_metrics-10         	  464810	      2403 ns/op	     176 B/op	       2 allocs/op
BenchmarkSerialization/UDP_plain_span_no_metrics-10           	  541394	      2488 ns/op	      80 B/op	       2 allocs/op
BenchmarkSerialization/UDP_plain_empty_span_with_metrics-10   	  536200	      2497 ns/op	     112 B/op	       2 allocs/op

# span.Marshal
BenchmarkSerialization/UDP_plain_span_with_metrics-10         	  511609	      2526 ns/op	     160 B/op	       1 allocs/op
BenchmarkSerialization/UDP_plain_span_no_metrics-10           	  635616	      1916 ns/op	      64 B/op	       1 allocs/op
BenchmarkSerialization/UDP_plain_empty_span_with_metrics-10   	  572904	      2157 ns/op	      96 B/op	       1 allocs/op

Rollout/monitoring/revert plan

  • PRE merge (if accepted): CHANGELOG.md

@andrewa-stripe andrewa-stripe merged commit 6fca04b into master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants