Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Router component needs a maintainer #72

Closed
andreypopp opened this issue Jul 26, 2014 · 14 comments
Closed

React Router component needs a maintainer #72

andreypopp opened this issue Jul 26, 2014 · 14 comments

Comments

@andreypopp
Copy link
Collaborator

Hello,

I'm not sure this library is still relevant in light of the new and awesome react-router but if someone still finds it useful then it needs a new maintainer! There some good PRs to be merged and some issues to be fixed. Also 1.x branch contains unfinished refactoring which should make rrc more modular and less error-prone.

@larrymyers
Copy link

This library is definitely still relevant, since react-router doesn't have an answer for server rendering yet, and rrc works just fine by supporting path as a prop to the Locations component.

@JaapRood
Copy link

@larrymyers that's exactly my beef with react-router and why I think rrc is definitely still relevant. Passing in the current path as a prop and having the components render correctly promotes proper encapsulation of code.

@jchristin
Copy link

Same feeling here

@sunetos
Copy link

sunetos commented Aug 20, 2014

Could you be persuaded to do one last batch of updates on rrc? You really did a great job on it, and it would be pretty difficult for a new maintainer to jump in with the number of outstanding pull requests and branches.

The main things I need in a react router:

  • ReactAsync compatibility
  • Server-side rendering that matches client-side based on path
  • Contextual links

I'm not sure, but I don't think any of those are provided by the other react-router project.

If you would be willing to do one last batch of updates to clean out oustanding issues and do a React v0.11 compatible release, it might be easier to transition to a new maintainer at that point.

@STRML
Copy link
Owner

STRML commented Aug 20, 2014

@sunetos See #77.

@STRML
Copy link
Owner

STRML commented Aug 20, 2014

@andreypopp I am happy to maintain the project in the future if you'd like.

@andreypopp
Copy link
Collaborator Author

@STRML alright! What's your npm username so I could add you there as a maintainer?

@STRML
Copy link
Owner

STRML commented Aug 20, 2014

@andreypopp Same as here but lowercase: strml.

@andreypopp
Copy link
Collaborator Author

@STRML done! thank you

@sunetos
Copy link

sunetos commented Aug 25, 2014

@STRML Thanks! Will try out soon.

@sunetos
Copy link

sunetos commented Aug 30, 2014

@STRML Can I ask what your plans are for maintenance of this project? Do you intend to revive it and keep the PRs going, or just do occasional releases for critical fixes?

I ask because I should have time to work on my React project again soon, and I'm deciding between writing my own lighter-weight replacement for this vs. contributing to this project.

@STRML
Copy link
Owner

STRML commented Aug 31, 2014

Hi Adam,

I plan to maintain this module, it's just the timing - I just got married!
So the last two weeks I have had no time for coding. I will get back on the
horse this week and start on the issues.
On Aug 30, 2014 5:46 PM, "Adam R. Smith" notifications@github.com wrote:

@STRML https://github.com/STRML Can I ask what your plans are for
maintenance of this project? Do you intend to revive it and keep the PRs
going, or just do occasional releases for critical fixes?

I ask because I should have time to work on my React project again soon,
and I'm deciding between writing my own lighter-weight replacement for this
vs. contributing to this project.


Reply to this email directly or view it on GitHub
#72 (comment)
.

@STRML
Copy link
Owner

STRML commented Aug 31, 2014

As for future plans, I use RRC in a company I cofound so I will be doing
all critical fixes and minor extensions, but PRs are always welcome.
On Aug 31, 2014 11:12 AM, samuel.trace.reed@gmail.com wrote:

Hi Adam,

I plan to maintain this module, it's just the timing - I just got married!
So the last two weeks I have had no time for coding. I will get back on the
horse this week and start on the issues.
On Aug 30, 2014 5:46 PM, "Adam R. Smith" notifications@github.com wrote:

@STRML https://github.com/STRML Can I ask what your plans are for
maintenance of this project? Do you intend to revive it and keep the PRs
going, or just do occasional releases for critical fixes?

I ask because I should have time to work on my React project again soon,
and I'm deciding between writing my own lighter-weight replacement for this
vs. contributing to this project.


Reply to this email directly or view it on GitHub
#72 (comment)
.

@sunetos
Copy link

sunetos commented Aug 31, 2014

That's great, congratulations! I have also been out of commission for a while for other life reasons, which is why I have been apprehensive to promise contributions of my own. It is now looking like I will be able to contribute, so I will focus on helping to fix up RRC instead of making a replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants