-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Router component needs a maintainer #72
Comments
This library is definitely still relevant, since react-router doesn't have an answer for server rendering yet, and rrc works just fine by supporting path as a prop to the Locations component. |
@larrymyers that's exactly my beef with react-router and why I think rrc is definitely still relevant. Passing in the current path as a prop and having the components render correctly promotes proper encapsulation of code. |
Same feeling here |
Could you be persuaded to do one last batch of updates on rrc? You really did a great job on it, and it would be pretty difficult for a new maintainer to jump in with the number of outstanding pull requests and branches. The main things I need in a react router:
I'm not sure, but I don't think any of those are provided by the other react-router project. If you would be willing to do one last batch of updates to clean out oustanding issues and do a React v0.11 compatible release, it might be easier to transition to a new maintainer at that point. |
@andreypopp I am happy to maintain the project in the future if you'd like. |
@STRML alright! What's your npm username so I could add you there as a maintainer? |
@andreypopp Same as here but lowercase: |
@STRML done! thank you |
@STRML Thanks! Will try out soon. |
@STRML Can I ask what your plans are for maintenance of this project? Do you intend to revive it and keep the PRs going, or just do occasional releases for critical fixes? I ask because I should have time to work on my React project again soon, and I'm deciding between writing my own lighter-weight replacement for this vs. contributing to this project. |
Hi Adam, I plan to maintain this module, it's just the timing - I just got married!
|
As for future plans, I use RRC in a company I cofound so I will be doing
|
That's great, congratulations! I have also been out of commission for a while for other life reasons, which is why I have been apprehensive to promise contributions of my own. It is now looking like I will be able to contribute, so I will focus on helping to fix up RRC instead of making a replacement. |
Hello,
I'm not sure this library is still relevant in light of the new and awesome react-router but if someone still finds it useful then it needs a new maintainer! There some good PRs to be merged and some issues to be fixed. Also
1.x
branch contains unfinished refactoring which should make rrc more modular and less error-prone.The text was updated successfully, but these errors were encountered: