Stop identifying group repositories as a single String

[fuss86]

Task Description

We have at least 3 places where we identify group repositories using String object:

• org.carlspring.strongbox.storage.repository.Repository#getGroupRepositories
• org.carlspring.strongbox.storage.repository.ImmutableRepository#groupRepositories
• org.carlspring.strongbox.storage.repository.MutableRepository#groupRepositories

There are 2 possible values of this object:

• when the group repository belongs to the same storage as the owner repository, we are using repositoryId as this String value.
• when the group repository does not belong to the same storage as the owner repository, we are using storageId:repositoryId as this String value.

This is not obvious, introduces misunderstandings and should become more clear.

We should create structure(s) for group repositories. Group repository should always be identified by storageId and repositoryId. Also, we should drop ConfigurationManager#getStorageId and ConfigurationManager#getRepositoryId and ConfigurationManager#getRepository(java.lang.String)

After making the necessary changes, make sure the UI still works as expected (i.e. Storage Management and Routing Management)

Help

• Our chat
• Points of contact:
  • @carlspring
  • @sbespalov
  • @fuss86

[carlspring]

@sbespalov , @steve-todorov ,

What are your thoughts on this?

[fuss86]

Any progress, @akhil10x5 ?

[akhil10x5]

Hi @fuss86, i did not pick up this issue. However regarding this, i tried few things earlier which did not work out but the changes were committed in a local branch which later got pushed to remote when i created a PR for another issue. I am not working on this anymore.

[fuss86]

What are your thoughts on this?

@sbespalov , @steve-todorov do you have any thoughts ? :)

[steve-todorov]

Sorry for the late reply on this.

I agree with you - we should create a new object type which has the storageId and repositoryId fields. This should then be used across Strongbox in that format and we should always have both fields.

Another place where this is being used is the Routing and specially the Repositories part which holds the list of accepted/denied repositories.

Changes made here will result in some broken UI, so whoever has interest in picking this up should also fix the UI if possible (or ping me when this is ready)