Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work out which Groovy dependencies we really need #1705

Open
5 tasks
carlspring opened this issue Mar 18, 2020 · 3 comments
Open
5 tasks

Work out which Groovy dependencies we really need #1705

carlspring opened this issue Mar 18, 2020 · 3 comments
Assignees

Comments

@carlspring
Copy link
Member

carlspring commented Mar 18, 2020

Task Description

We currently have several places that are using the groovy dependencies. For example:

We need to be more specific in regards to which exact Groovy dependencies we really need, because these can be very problematic (if multiple transitive dependencies are bringing different versions of the Groovy dependencies, this causes incompatibility issues).

The work will have to be done against the issues/1649 branch.

Dependency Tree

  • strongbox-data-service:
+- org.apache.tinkerpop:gremlin-groovy:jar:3.4.6:compile
|  +- org.apache.ivy:ivy:jar:2.3.0:compile
|  +- org.codehaus.groovy:groovy-groovysh:jar:indy:2.5.7:compile
|  |  +- org.codehaus.groovy:groovy-cli-picocli:jar:2.5.9:compile
|  |  |  \- info.picocli:picocli:jar:4.0.1:compile
|  |  +- org.codehaus.groovy:groovy-console:jar:2.5.9:compile
|  |  |  +- org.codehaus.groovy:groovy-templates:jar:2.5.9:compile
|  |  |  |  \- org.codehaus.groovy:groovy-xml:jar:2.5.9:compile
|  |  |  \- org.codehaus.groovy:groovy-swing:jar:2.5.9:compile
|  |  \- jline:jline:jar:2.14.6:compile
|  \- org.codehaus.groovy:groovy-jsr223:jar:indy:2.5.7:compile

Tasks

The following tasks will need to be carried out:

  • Identify the required dependencies
  • Add exclusions for all the transitive groovy-* dependencies that we don't really need
  • Apply the necessary changes to the strongbox-parent
  • Apply the necessary changes to the strongbox-data-service
  • Apply the necessary changes to the strongbox-cron-api and strongbox-cron-tasks modules

Task Relationships

This task:

Help

@carlspring carlspring changed the title Workout which Groovy dependencies we really need Work out which Groovy dependencies we really need Mar 18, 2020
@ykabusalah

This comment has been minimized.

@anki2189
Copy link
Member

anki2189 commented Apr 12, 2020

We don't need groovy-all dependency as of now as it pull many transitive dependencies which are not compatible with this project. Below are the required groovy dependencies.

  • groovy

  • groovy-json

  • groovy-xml

After #1701 minimum required version will be 3.0.2

@carlspring
Copy link
Member Author

@anki2189 ,

Thanks for the update!

Please, bear in mind that:

Could you please make sure this works properly on Sergey's branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants