Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove our Travis Github check #1952

Open
2 tasks
carlspring opened this issue Nov 1, 2020 · 2 comments
Open
2 tasks

Remove our Travis Github check #1952

carlspring opened this issue Nov 1, 2020 · 2 comments
Assignees
Labels

Comments

@carlspring
Copy link
Member

carlspring commented Nov 1, 2020

Task Description

We were using Travis for our builds under MacOS. This used to work in the past, however, lately it constanly times out, simply because our complete build takes a while to complete and Travis simply kills it, if it exceeds the time. When this fails, the checks in pull requests fail.

Tasks

The following tasks will need to be carried out:

  • Remove the Travis script.
  • Remove our Travis hooks. (@steve-todorov ?)

Relationship:

Help

@carlspring carlspring added help wanted hacktoberfest Pre-selected issues for Hacktoberfest labels Nov 1, 2020
@steve-todorov steve-todorov added on hold and removed hacktoberfest Pre-selected issues for Hacktoberfest help wanted labels Nov 2, 2020
@steve-todorov steve-todorov self-assigned this Nov 2, 2020
@j4ckofalltrades
Copy link
Contributor

@steve-todorov

Regarding discussion in chat about JDK8 and the macOS build environment in Travis CI; from the docs:

While Mac jobs can test against multiple JDK versions using the jdk key, macOS images up to xcode9.3 can only switch up to Java 8

So something like this should work:

# .travis.yml

jdk:
  - oraclejdk8
  - openjdk8

script:
  - # use openjdk8 for this build
  - jdk_switcher use openjdk8

Alternatively, we can use the homebrew addon and set JAVA_HOME to this jdk.

# .travis.yml

osx_image: xcode9.3
addons:
  homebrew:
    taps: homebrew/cask-versions
    casks: adoptopenjdk8

@steve-todorov
Copy link
Member

Hey, thanks for checking into it! I've created a separate task for this #1956. If you're up for upgrading the JDK - feel free to comment under it and I'll assign it to you. :)

You can try with the jdk: [ -openjdk8 ] approach - if the JDK is >= 1.8.0_222 then it'll work. Otherwise you'll probably need to go the homebrew path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants