Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay returned on cache lookup #11

Open
emidln opened this issue Dec 4, 2014 · 2 comments
Open

Delay returned on cache lookup #11

emidln opened this issue Dec 4, 2014 · 2 comments

Comments

@emidln
Copy link

emidln commented Dec 4, 2014

I'm probably just missing something here, but why does lookup return a Delay? It's pretty frustrating to need to check delay? or force just for crache when other core.cache backends don't return Delays.

@strongh
Copy link
Owner

strongh commented Dec 5, 2014

I'm afraid that this was an oversight on my part- the delay were at one time optional (so that you could ask for a lookup before you needed, potentially an optimization), but I did not intend to return delays exclusively. I think this was brought in by #7, which included several other changes that seem to work well. I'm a bit busy at the moment, but I would accept a PR to re-add the option for delays.

@behrica
Copy link

behrica commented Jun 30, 2023

I fixed this in my fork: https://github.com/behrica/crache
and merged as well 2 PRs: #15 #16

@strongh Do you want to include this changes in here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants