Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #56

Closed
bajtos opened this issue Dec 5, 2014 · 3 comments
Closed

Code cleanup #56

bajtos opened this issue Dec 5, 2014 · 3 comments

Comments

@bajtos
Copy link
Contributor

bajtos commented Dec 5, 2014

See android-async-http/android-async-http#751

  1. We now support HEAD requests,
    https://github.com/strongloop/loopback-sdk-android/blob/4587dd82946c6a6647b60bd89ca74ad4ca66a481/src/main/java/com/strongloop/android/remoting/adapters/RestAdapter.java#L303

  2. Your BinaryHandler and CallbackHandler override specific methods, check if you're overriding the ones you want (there are few variants of every callback method, depending on what type of information you do want/need about the request/response processing.

  3. You could probably want to change declarations to require ResponseHandlerInterface instead of AsyncHttpResponseHandler

@yoshuacas
Copy link

Hi bajtos,

I noticed that you found this issue last year and tried to follow the discussion you had with the Loopj team, but I don't find a way to go around this issue, is there a way for me to work around it? I noticed you have it as an enhacement when in fact its breaking the sdk ugly.

I'm finding this when I try to PUT on my customized User Model, I'm simply trying to update a user property. I don't find it when doing a creation.

Thanks for the advice,

@bajtos
Copy link
Contributor Author

bajtos commented Mar 11, 2015

@yoshuacas What exactly is your issue? Can you please provide specific steps how I can reproduce it on my machine?

@dhmlau
Copy link
Contributor

dhmlau commented Apr 6, 2018

Closing due to inactivity

@dhmlau dhmlau closed this as completed Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants