Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findAll: Read partitionKey from options #220

Closed
1 task done
jannyHou opened this issue Oct 8, 2019 · 3 comments
Closed
1 task done

findAll: Read partitionKey from options #220

jannyHou opened this issue Oct 8, 2019 · 3 comments
Assignees
Labels

Comments

@jannyHou
Copy link
Contributor

jannyHou commented Oct 8, 2019

See parent story: #214

Acceptance Criteria

  • For method Couchdb2.prototype.all()(which maps to model method find), get the partition key from options like:
     Customer.find({
        where: { name: 'somename' }
     },
     {
        // options
        partitonKey: 'US'
     });
    If partitionKey is found, then invoke driverInst.partitionedFind(partitionKey, query) to find documents.
@jannyHou
Copy link
Contributor Author

jannyHou commented Oct 8, 2019

Discussion point: The notation of option:

  • {partitionkey: 'US'}
    or
  • {cloudantOptions: {partitionKey: 'US'}}

Let's decide which one to use when implement this feature.

@raymondfeng
Copy link

It should be {cloudant: {partitionKey: 'US'}} or {partitionKey: 'US'}.

@jannyHou
Copy link
Contributor Author

Closing since PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants