fix: throws when the custom id field name is set #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnes512
requested review from
dhmlau,
emonddr,
hacksparrow and
jannyHou
as code owners
emonddr
approved these changes
Apr 21, 2020
hacksparrow
approved these changes
Apr 21, 2020
jannyHou
approved these changes
Apr 21, 2020
README.md
Outdated
| @@ -288,6 +288,39 @@ module.exports = function(app) { | |||
| }; | |||
| ``` | |||
|
|
|||
| ### Customize collection/field names | |||
|
|
|||
| loopback-connector-mongodb allows you to have different collection and field names from the models. For example, the following setting would define a collection with custom name `Custom_Collection`, and it has a custom field name `Custom_Content` in the database: | |||
There was a problem hiding this comment.
Suggested change
| loopback-connector-mongodb allows you to have different collection and field names from the models. For example, the following setting would define a collection with custom name `Custom_Collection`, and it has a custom field name `Custom_Content` in the database: | |
| nitpick: `loopback-connector-mongodb` allows you to have different collection and field names from the models. For example, the following setting would define a collection with custom name `Custom_Collection`, and it has a custom field name `Custom_Content` in the database: |
|
@slnode test please |
|
@slnode test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to loopbackio/loopback-next#5042
LB4 mongoDB connector doesn't support custom field name for id properties. However, it doesn't throw or warn if the name is set.
getDatabaseColumnNameis the only method to handle custom names. This PR adds some checks and throws if the custom id property name is set.Checklist
馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟
npm testpasses on your machine