- Adds support for long JSON strings when using embedOne
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… models. - Converts JSON columns to TEXT for extra length allowance
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
This reverts commit 5e81bce.
embedsOne relation is picked up as `default`, therefore we need to keep the default value for now as TEXT.
| @@ -527,7 +527,7 @@ function mixinMigration(PostgreSQL) { | |||
| default: | |||
| case 'String': | |||
| case 'JSON': | |||
| return 'VARCHAR' + (colLength ? '(' + colLength + ')' : '(1024)'); | |||
| return 'TEXT'; | |||
| case 'Text': | |||
| return 'VARCHAR' + (colLength ? '(' + colLength + ')' : '(1024)'); | |||
There was a problem hiding this comment.
This should be TEXT too, right?
There was a problem hiding this comment.
Yes agree, will update now.
…or-postgresql - modifies `Text` loopback type mapping to `text` in postgres
|
LGTM |
superkhau
added a commit
that referenced
this pull request
Mar 16, 2016
- Adds support for long JSON strings when using `embedOne`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, we are unable to use postgresql as a datasource for some model relations that use the
embedsOne. This is because the previous default value for detected JSON data types isVARCHAR(1024). Now by default, the column data type will betext, allowing for long JSON strings to be imported into the database.References issue: #131