Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bluebird promise library instead of global.Promise #98

Closed
1 of 2 tasks
mrfelton opened this issue Jul 25, 2017 · 2 comments
Closed
1 of 2 tasks

Use bluebird promise library instead of global.Promise #98

mrfelton opened this issue Jul 25, 2017 · 2 comments
Labels

Comments

@mrfelton
Copy link

mrfelton commented Jul 25, 2017

Bug or feature request

  • Bug
  • Feature request

Description of feature (or steps to reproduce if bug)

Loopback 3.x no longer relies on global.Promise and instead explicitly uses bluebird for promises. This module should follow suit for better compatibility with loopback 3.x where bluebird is used extensively and many users will not have global.Promise set (this is no longer recommended.

The current situation is that if you don't have global.Promise set, you end up with native es6 promises being returned by this modules methods which are not particularly good to work with and can cause unexpected issues when users try to use bluebird methods on them as they would with the rest of their loopback code.

mrfelton pushed a commit to fullcube/loopback-connector-rest that referenced this issue Jul 25, 2017
@stale stale bot added the stale label Sep 23, 2017
@stale
Copy link

stale bot commented Sep 23, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Oct 7, 2017

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant