Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API docs #80

Merged
merged 5 commits into from Jun 22, 2017
Merged

Fix API docs #80

merged 5 commits into from Jun 22, 2017

Conversation

crandmck
Copy link
Contributor

@crandmck crandmck commented Feb 24, 2017 •
edited by ssh24

PLEASE DO NOT MERGE YET.

This is to address #54. Changes so far in this PR fix the problem with the [ ] characters and it now properly displays docs for base Connector and SQLConnector, but oddly the docs for parameterized-sql.js is now not there. Also, the navigation seems to be pretty broken, and I don't really know why.

@0candy Perhaps you can shed some light?

connect to #54

@0candy
Copy link
Contributor

0candy commented Feb 27, 2017 •
edited

@crandmck The base connector docs are showing on the left side bar but the actual docs are not there.

@crandmck
Copy link
Contributor Author

Yeah, something's messed up. :-( I'll try to figure it out.

@crandmck crandmck mentioned this pull request Mar 15, 2017
Closed
@siddhipai siddhipai added review and removed review labels Mar 20, 2017
@dhmlau dhmlau added the apex label Jun 21, 2017
@ssh24 ssh24 removed the review label Jun 21, 2017
@ssh24 ssh24 self-assigned this Jun 22, 2017
@crandmck
Copy link
Contributor Author

crandmck commented Jun 22, 2017 •
edited

Still at least one spurious entry in the nav that don't appear in the content area:

2017-06-22_0907

@ssh24 ssh24 force-pushed the fix-api-docs branch 3 times, most recently from b602983 to 6c401dc Compare June 22, 2017 16:25
@ssh24
Copy link
Contributor

ssh24 commented Jun 22, 2017

@crandmck That should be fixed now.

@crandmck
Copy link
Contributor Author

OK, I know I can't officially approve this PR, since I opened it, but LGTM!
Thanks, @ssh24 !

0candy
0candy approved these changes Jun 22, 2017
View reviewed changes
Copy link
Contributor

@0candy 0candy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @ssh24 , LGTM

@ssh24 ssh24 merged commit d1d2452 into master Jun 22, 2017
@ssh24 ssh24 deleted the fix-api-docs branch June 22, 2017 17:06
@ssh24 ssh24 added this to the Sprint 38 - Apex milestone Jun 22, 2017
kjdelisle pushed a commit that referenced this pull request Jul 17, 2017
4.2.2
a22d8cb 
 * Fix transaction (Diana Lau)
 * Fix comment lines (Quentin Presley)
 * Fix API docs (#80) (Rand McKinney)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0candy 0candy 0candy approved these changes

Assignees

@ssh24 ssh24

Labels
None yet
Projects
None yet
Milestone
Sprint 38 - Apex
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crandmck @0candy @ssh24 @siddhipai @dhmlau