Merge 3342718 into 5f713f0

loopbackio · Dec 6, 2018 · d631f02 · d631f02
2 parents 5f713f0 + 3342718
commit d631f02
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 0 deletions.
diff --git a/lib/connectors/memory.js b/lib/connectors/memory.js
@@ -255,6 +255,21 @@ Memory.prototype._createSync = function(model, data, fn) {
     this.collection(model, {});
   }
 
+  var indexes = this._models[model].model.definition.indexes();
+  for (var idx in indexes) {
+    var idxPropName = idx.substring(0, idx.indexOf('_index'));
+    if (indexes[idx].unique === true) {
+      for (var instId in this.cache[model]) {
+        var inst = JSON.parse(this.cache[model][instId]);
+        if (inst[idxPropName] === data[idxPropName]) {
+          var duplicateIndexError = new Error(g.f('Duplicate entry for %s.%s', model, idxPropName));
+          duplicateIndexError.statusCode = duplicateIndexError.status = 409;
+          return fn(duplicateIndexError);
+        }
+      }
+    }
+  }
+
   if (this.collection(model)[id]) {
     var error = new Error(g.f('Duplicate entry for %s.%s', model, idName));
     error.statusCode = error.status = 409;

diff --git a/test/memory.test.js b/test/memory.test.js
@@ -677,6 +677,24 @@ describe('Memory connector', function() {
     });
   });
 
+  it('should refuse to create object with duplicate unique index', function(done) {
+    var ds = new DataSource({connector: 'memory'});
+    var Product = ds.define('ProductTest', {name: {type: String, index: {unique: true}}}, {forceId: false});
+    ds.automigrate('ProductTest', function(err) {
+      if (err) return done(err);
+
+      Product.create({name: 'a-name'}, function(err, p) {
+        if (err) return done(err);
+        Product.create({name: 'a-name'}, function(err) {
+          should.exist(err);
+          err.message.should.match(/Duplicate/i);
+          err.statusCode.should.equal(409);
+          done();
+        });
+      });
+    });
+  });
+
   describe('automigrate', function() {
     var ds;
     beforeEach(function() {