Fix bug with bson objects in utils uniq function #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbouda
requested review from
b-admike,
dhmlau,
jannyHou,
kjdelisle,
virkt25 and
zbarbuto
as code owners
The uniq function does currently not work when the database is mongodb. In the case of mongodb, the function will receive an array of bson object of bson type ObjectID. The indexOf function will return a different index, even if the mongodb ID is the same, as it is wrapped in the ObjectID. This commit first transforms any ObjectID in the array to a string representation. We can then use indexOf to check for uniqueness.
|
@slnode test please |
2 tasks
|
@pbouda I'm good with this PR, but only if we switch to the bson implementation of ObjectID in the mongodb connector (I've created a linked PR for this). @raymondfeng Your thoughts? |
kjdelisle
approved these changes
Nov 30, 2017
|
@slnode test please |
|
@kjdelisle yes, makes sense to use bson also in the mongodb connector. |
|
@slnode test please |
|
@pbouda The failures don't seem related to any of the changes made; once the CI run is done, I'll check any remaining failures and if they're all bogus, then I'll land this. |
|
🎉 @pbouda Thank you for your contribution! 🎉 |
kjdelisle
pushed a commit
that referenced
this pull request
Dec 14, 2017
* Allow new transaction method in postgresql (#1493) (zbarbuto) * Fix bug in utils uniq function (#1526) (Peter Bouda) * Fix query for related models (#1522) (Joost de Bruijn) * chore:update license (#1521) (Diana Lau) * Allow customizing embedded relation property (#1513) (zbarbuto) * 📖 Typo on README.md (#1517) (JP Ventura) * CODEOWNERS: move @lehni to Alumni section (Miroslav Bajtoš)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The uniq function does currently not work when the database is mongodb. In the case of mongodb, the function will receive an array of bson object of bson type ObjectID. The indexOf function in uniq will return a different index for the same mongodb ID, as it is wrapped in the ObjectID. This results in an array that has duplicate mongodb IDs. This commit first transforms any ObjectID in the given array to a string representation. We can then use indexOf to return unique items.
Replaces PR: #1418
Related issues
Checklist
guide