feat(datasource): set named datasource with settings option #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truongminh
requested review from
b-admike,
dhmlau,
jannyHou,
kjdelisle,
virkt25 and
zbarbuto
as code owners
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
truongminh
force-pushed
the
set-datasource-name
branch
from
a236c9a
to
80f9364
Compare
raymondfeng
reviewed
Feb 8, 2018
| @@ -335,14 +335,14 @@ DataSource.prototype.connect = function(callback) { | |||
| * @returns {*} | |||
| * @private | |||
| */ | |||
| DataSource.prototype.setup = function(name, settings) { | |||
| DataSource.prototype.setup = function(connectorName, settings) { | |||
There was a problem hiding this comment.
The name argument is the name of the dataSource. It should be changed to dsName to make it obvious.
raymondfeng
requested changes
Feb 8, 2018
2 tasks
|
Close it to favor #1555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to set an the appropriate name for the datasource.
In the existing code,
this.namerefers to the connector name.In this PR, that name is changed to
this.connectorName, while keeping theDataSource's methods unchanged to the outside.That
.nameis nowsettings.name || connector.nameand is used to find the datasource within an application context.Related comments can be found here:
loopbackio/loopback-next#966 (comment)
@bajtos do you have any suggestion on this?