Report errors for missing id properties for include #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
requested review from
b-admike,
dhmlau,
jannyHou,
virkt25 and
zbarbuto
as code owners
b-admike
reviewed
Oct 18, 2018
| User.findOne({include: {relation: 'profile'}, fields: 'name'}, function(err, user) { | ||
| should.not.exist(err); | ||
| should.exist(user); | ||
| should.not.exist(user.toJSON().profile); |
There was a problem hiding this comment.
I'm wondering if we should error out here as well and say that the id property is missing. Thoughts?
There was a problem hiding this comment.
For belongsTo and hasOne, the FK can be null from business function perspective. We can have an option to report as errors if necessary.
bajtos
reviewed
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strongloop/loopback#4028
Description
Related issues
Checklist
guide