Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hidden/protected property checks #1649

Merged
merged 2 commits into from Oct 29, 2018
Merged

Improve hidden/protected property checks #1649

merged 2 commits into from Oct 29, 2018

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Oct 28, 2018 •
edited

Description

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@raymondfeng
Improve hidden/protected property checks
8fa7c94 
- Fixes #1645
  - do not apply hidden property check for data
- Fixes #1648
  - allow prohibitHiddenPropertiesInQuery to be set in model/ds
@raymondfeng raymondfeng mentioned this pull request Oct 28, 2018
Closed
@hacksparrow hacksparrow mentioned this pull request Oct 29, 2018
Closed
hacksparrow
hacksparrow approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@hacksparrow hacksparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Login works now and security measures are still in place. It is an improvement over the last build and should be published to fix the login problem.

@raymondfeng raymondfeng merged commit 7609585 into master Oct 29, 2018
@bajtos bajtos deleted the fix-1645 branch October 30, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacksparrow hacksparrow hacksparrow approved these changes

@b-admike b-admike Awaiting requested review from b-admike

@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau is a code owner

@jannyHou jannyHou Awaiting requested review from jannyHou

@virkt25 virkt25 Awaiting requested review from virkt25

@zbarbuto zbarbuto Awaiting requested review from zbarbuto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@raymondfeng @hacksparrow @bajtos