Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint-config-loopback to latest (3.x) #1676

Merged
merged 3 commits into from Dec 7, 2018
Merged

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Dec 7, 2018

Description

This is a back-port of #1675 and #1674, where we are refactoring our code base to use const instead of var.

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@bajtos bajtos self-assigned this Dec 7, 2018
@bajtos bajtos requested review from raymondfeng and removed request for jannyHou December 7, 2018 16:17
@bajtos bajtos changed the title Upgrade eslint-config-loopback to latest Upgrade eslint-config-loopback to latest (3.x) Dec 7, 2018
@bajtos
Copy link
Member Author

bajtos commented Dec 7, 2018

Quite few connectors are failing on the following test:

      include
         should report errors if the PK is excluded:
     Uncaught AssertionError: expected null to exist
      at /home/jenkins/workspace/ds/loopback-connector-mssql~master/node_modules/loopback-datasource-juggler/test/include.test.js:81:14
     at /home/jenkins/workspace/ds/loopback-connector-mssql~master/node_modules/loopback-datasource-juggler/lib/dao.js:1707:9

I need to investigate if this could be a problem caused by my changes.

@bajtos
Copy link
Member Author

bajtos commented Dec 7, 2018

ok, those build failures are present when using the latest published version of juggler@3 too.

@bajtos bajtos merged commit e141693 into 3.x Dec 7, 2018
@bajtos bajtos deleted the upgrade-eslint-config-3x branch December 7, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants