chore: add beginTransaction API to declaration file #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-admike
requested review from
dhmlau,
emonddr,
jannyHou and
zbarbuto
as code owners
raymondfeng
reviewed
Jun 24, 2019
raymondfeng
reviewed
Jun 24, 2019
| beginTransaction( | ||
| options?: Options, | ||
| callback?: Callback<Transaction>, | ||
| ): PromiseOrVoid<Transaction>; |
There was a problem hiding this comment.
Do we export Transaction?
There was a problem hiding this comment.
Yes from transaction-mixin and I believe we export it from juggler module too.
raymondfeng
reviewed
Jun 24, 2019
raymondfeng
reviewed
Jun 24, 2019
types/persisted-model.d.ts
Outdated
| /** | ||
| * Reload object from persistence. Requires `id` member of `object` to be able to call `find`. | ||
| * @callback {Function} callback Callback function called with `(err, instance)` arguments. Required. | ||
| * @param {Error} err Error object; see [Error object](http://loopback.io/doc/en/lb2/Error-object.html). | ||
| * @param {Object} instance Model instance. | ||
| */ | ||
| reload( | ||
| options?: Options, | ||
| options?: string | Options, |
There was a problem hiding this comment.
Isn't string | Options for beginTransaction instead?
raymondfeng
reviewed
Jun 24, 2019
types/persisted-model.d.ts
Outdated
| * @returns {Promise|undefined} Returns a callback promise. | ||
| */ | ||
| beginTransaction( | ||
| options?: Options, |
b-admike
force-pushed
the
update/ds-declaration-file
branch
2 times, most recently
from
9633e2f
to
21a9d7f
Compare
raymondfeng
approved these changes
Jun 24, 2019
b-admike
force-pushed
the
update/ds-declaration-file
branch
from
21a9d7f
to
313925a
Compare
nabdelgadir
approved these changes
Jun 24, 2019
Actually I took the documentation from https://github.com/strongloop/loopback-datasource-juggler/blob/master/lib/transaction.js#L27-L73 😁 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connect to loopbackio/loopback-next#2614. We need to add
beginTransaction()to the persisted model declaration file in order to utilize it with LB4 repositories.Related issues
Checklist
guide