array_type_field_filter: Adds contains filter for postgresDB #1865
Conversation
shubhisood
requested review from
dhmlau,
emonddr,
jannyHou and
zbarbuto
as code owners
|
@shubhisood Thank you for the PR. Please sign DCO (https://loopback.io/doc/en/contrib/code-contrib.html). |
| @@ -88,6 +88,7 @@ const operators = { | |||
| ilike: 'ILIKE', | |||
| nilike: 'NOT ILIKE', | |||
| regexp: 'REGEXP', | |||
| contains: '@>', | |||
There was a problem hiding this comment.
Please note that the operator needs to be supported by other LoopBack db connectors beyond Postgres. Do we have some ideas about the feasibility of other DBs?
There was a problem hiding this comment.
@raymondfeng This feature is so much needed. We literally had to hack our way into Loopback as we needed it extensively. Please figure out a way to get this merged.
There was a problem hiding this comment.
@raymondfeng currently i have added it only for postgres db, not sure how we may implement it for other db connectors as well, i may need to look into this..
There was a problem hiding this comment.
I agree with @raymondfeng that we must keep other connectors in mind when making any changes in juggler.
Is it possible to implement array coercion of contains filter inside the postgresql connector?
In MongoDB, we have the concept of extended operators, see line 507 later in this file.
Can we perhaps use the same mechanism for PostgreSQL?
There was a problem hiding this comment.
I need to check into this @bajtos will inform you after analysis.
There was a problem hiding this comment.
@bajtos you are right after using allowExtendedOperators option within postgres connector model, I am able to handle the case for array field filter, we can close this PR after postgres connector specfic PR gets approved.
shubhisood
force-pushed
the
array_type_field_filter
branch
from
9340472
to
982f97e
Compare
shubhisood
changed the title
1. Adds new filter for array type field. 2. From this filter you can search from array type field. Signed-off-by: shubhisood <shubhi.sood@sourcefuse.com>
shubhisood
force-pushed
the
array_type_field_filter
branch
from
982f97e
to
d953eab
Compare
|
Travis build is failing because the following PR related to juggler needs to be merged first: |
There was a problem hiding this comment.
Thank you @shubhisood for the pull request. It makes a lot of sense to me to support additional database-specific operators like contains 👍
However, we need to find a solution that will work for all juggler users, regardless of the connector they are using.
| @@ -88,6 +88,7 @@ const operators = { | |||
| ilike: 'ILIKE', | |||
| nilike: 'NOT ILIKE', | |||
| regexp: 'REGEXP', | |||
| contains: '@>', | |||
There was a problem hiding this comment.
I agree with @raymondfeng that we must keep other connectors in mind when making any changes in juggler.
Is it possible to implement array coercion of contains filter inside the postgresql connector?
In MongoDB, we have the concept of extended operators, see line 507 later in this file.
Can we perhaps use the same mechanism for PostgreSQL?
|
Closing per #1865 (comment)
|
Adds contains filter to make searches on Array type field.
Fixes #342 of loopback-postgres connector
Checklist
npm testpasses on your machine