Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove impossible condition. #1882

Closed
wants to merge 6 commits into from
Closed

Remove impossible condition. #1882

wants to merge 6 commits into from

Conversation

ferrantejake
Copy link

Removes impossible-to-fulfill condition which expects the error message to match the name of the path of a connector.

This fix addresses the issue here: #1866

Checklist

  • Sign off your commits with DCO (Developer Certificate of Origin)
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

Signed-off-by: ferrantejake <jake.ferrante@hotmail.com>
Signed-off-by: ferrantejake <jake.ferrante@hotmail.com>
@ferrantejake
Copy link
Author

I tried to squash the commits into a single commit that was signed off.. sorry for the messy commit history. Not really sure how to get those commits signed off at this point. Open to closing this PR and creating a new one if that's what it takes.

@dhmlau
Copy link
Member

dhmlau commented Dec 4, 2020

@ferrantejake, this is what i usually do:

git clone ${forked repository url}
cd ${repo}
git checkout ${branch user used to open PR}
git remote add upstream ${strongloop repo url}
git remote -v // optional - used to verify remotes you have setup
git fetch upstream
git rebase -i upstream/master 
// rebase + re-word / change commit message as usual and exit edit mode
git push origin +${branch you are on -- the one user used to open PR}

@dhmlau dhmlau added the community-contribution Patches contributed by community label Dec 4, 2020
@ferrantejake
Copy link
Author

Thanks for the guide, still having trouble with this so I am going to close it and open another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Patches contributed by community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants