Reject CREATE with a duplicate id #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
force-pushed
the
fix/duplicate-create
branch
from
008c642
to
4bef850
Compare
bajtos
changed the title
bajtos
force-pushed
the
fix/duplicate-create
branch
from
4bef850
to
6f771f5
Compare
bajtos
force-pushed
the
fix/duplicate-create
branch
from
4645614
to
80ab8cf
Compare
| @@ -210,6 +210,11 @@ Memory.prototype.create = function create(model, data, callback) { | |||
| if(!this.collection(model)) { | |||
| this.collection(model, {}); | |||
| } | |||
|
|
|||
| if (this.collection(model)[id]) { | |||
| return callback(new Error('Duplicate entry for ' + model + '.' + idName)); | |||
There was a problem hiding this comment.
We should make the callback inside process.nextTick so that the async expectation is guaranteed.
added 2 commits
March 16, 2015 18:26
Modify the memory connector to reject requests to create a record with a duplicate id. Add a unit-test to verify this behaviour across all connectors.
Before this commit, the following code would not work:
Change.updateOrCreate({...}, function(err, ch) {
// somewhere later, modify "ch" and save the changes
ch.save(cb);
});
bajtos
force-pushed
the
fix/duplicate-create
branch
from
80ab8cf
to
6f11c2d
Compare
|
LGTY now? |
|
LGTM |
bajtos
added a commit
that referenced
this pull request
Mar 19, 2015
Reject CREATE with a duplicate id
This was referenced Mar 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the memory connector to reject requests to create a record with a duplicate id.
Add a unit-test to verify this behaviour across all connectors.
Connect to strongloop/loopback#986
/to @raymondfeng please review