Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation sidebar doesn't open child topics when viewing container topic #35

Closed
crandmck opened this issue Aug 23, 2016 · 1 comment
Closed
Labels

Comments

@crandmck
Copy link
Contributor

crandmck commented Aug 23, 2016

The original implementation of the sidebar didn't allow sidebar container items to be linked to a topic. You can see the default implementation in http://idratherbewriting.com/documentation-theme-jekyll/: The sidebar container items "Overview", "Release Notes", "Installation", etc. are only containers, they are not pages themselves.

But since our topic hierarchy was laid out such that containers were also themselves topics, I changed the _includes/sidebar.html template to allow for that. However, the problem now is that when you click on a container topic, it doesn't "expand" the child topics; you have to click the inverted triangle to do that. While this works, it's inconvenient and could be confusing.

I'd like the child topics to be displayed by default. So, for example, when you click on LoopBack core concepts, I'd like it to expand the child topics underneath ("Routing", "LoopBack FAQ", etc) as well as display the "LoopBack core concepts" page.

@crandmck
Copy link
Contributor Author

Fixed by e377bcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant