Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper variable names #182

Merged
merged 1 commit into from Aug 17, 2018
Merged

fix: use proper variable names #182

merged 1 commit into from Aug 17, 2018

Conversation

b-admike
Copy link
Contributor

Description

Fix to use proper variable names. Those using complex WSDLs will probably run into this issue with the following error:

/Users/badmike/loopback/strong-soap/example/json2xmlwithschema.js:57
      ].children[1].describe(wsdl.definitions),
        ^

TypeError: Cannot read property 'children' of undefined
    at /Users/badmike/loopback/strong-soap/example/json2xmlwithschema.js:57:9
    at /Users/badmike/loopback/strong-soap/src/parser/wsdl.js:105:9
    at WSDL._processNextInclude (/Users/badmike/loopback/strong-soap/src/parser/wsdl.js:162:14)
    at WSDL.processIncludes (/Users/badmike/loopback/strong-soap/src/parser/wsdl.js:221:10)
    at /Users/badmike/loopback/strong-soap/src/parser/wsdl.js:60:12
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@b-admike b-admike merged commit 609cb58 into master Aug 17, 2018
@b-admike b-admike deleted the fix/variable-names branch August 17, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants