Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary files from npm packages #250

Merged
merged 1 commit into from Feb 10, 2020
Merged

Remove unnecessary files from npm packages #250

merged 1 commit into from Feb 10, 2020

Conversation

avindra
Copy link
Contributor

@avindra avindra commented Nov 28, 2019

Update .npmignore to avoid shipping garbage files to consumers on npm

The largest folder is coverage, sitting at 1.8MB.

$ du -h -d1 strong-soap/  | sort -h
0       strong-soap/node_modules
4.0K    strong-soap/.vscode
8.0K    strong-soap/.github
60K     strong-soap/example
72K     strong-soap/xsds
120K    strong-soap/intl
432K    strong-soap/lib
440K    strong-soap/src
476K    strong-soap/.nyc_output
1.8M    strong-soap/coverage
3.5M    strong-soap/

Update `.npmrc` to avoid shipping garbage files to consumers on npm

The largest folder is `coverage`, sitting at 1.8MB.

```
$ du -h -d1 strong-soap/  | sort -h
0       strong-soap/node_modules
4.0K    strong-soap/.vscode
8.0K    strong-soap/.github
60K     strong-soap/example
72K     strong-soap/xsds
120K    strong-soap/intl
432K    strong-soap/lib
440K    strong-soap/src
476K    strong-soap/.nyc_output
1.8M    strong-soap/coverage
3.5M    strong-soap/
```
@avindra
Copy link
Contributor Author

avindra commented Nov 28, 2019

Arguably, example can be removed as well since it's not needed for consuming the library.

Can update the PR to include that if it's a good idea.

@avindra
Copy link
Contributor Author

avindra commented Jan 11, 2020

@b-admike @raymondfeng happy new year 🎉

have you had a chance to look at this?

@raymondfeng raymondfeng merged commit 38a5561 into loopbackio:master Feb 10, 2020
@avindra avindra deleted the patch-1 branch February 24, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants